Conversation
feat(a11y): add accessibility improvements in components
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 99c08c1cab
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| onKeyDown={(event: React.KeyboardEvent<HTMLSpanElement>) => { | ||
| if (event.key === 'Enter' || event.key === ' ') { | ||
| event.preventDefault(); | ||
| resizeCol({ updateColumnSchema }, name, el.current); | ||
| setIsDragged(false); |
There was a problem hiding this comment.
Pressing Enter/Space on the resize handle now calls resizeCol(...), but that helper (core/components/organisms/grid/columnUtility.tsx) always registers a global mousemove listener and only removes it on a later mouseup. Keyboard activation does not initiate a mouse drag, so this can leave resize mode armed and cause unexpected column width changes on the next mouse movement until a click happens. Use a keyboard-specific resize behavior instead of invoking the mouse-drag path from onKeyDown.
Useful? React with 👍 / 👎.
| role="button" | ||
| tabIndex={0} |
There was a problem hiding this comment.
FileListItem now always renders with role="button" and tabIndex={0} even when onClick is absent. In that scenario, keyboard users can tab to an element announced as interactive, but activation does nothing because handleKeyDown exits early when no handler exists. This introduces inert tab stops and misleading accessibility semantics in non-clickable file lists.
Useful? React with 👍 / 👎.
1 participant
What does this implement/fix? Explain your changes.
...
Does this close any currently open issues?
...
Any other comments?
...
Dependent PRs/Commits
...
Describe breaking changes, if any.
...
Checklist
Check all those that are applicable and complete.
masterbranch